View Issue Details

IDProjectCategoryView StatusLast Update
0013382Tine 2.0Timetrackerpublic2017-08-11 11:26
ReporterjohnasselAssigned Tomspahn 
PriorityurgentSeverityblockReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSFedoraOS Version26
Product Version2017.08.1 Community Edition 
Target Version2017.08.2 Community EditionFixed in Version2017.08.2 Community Edition 
Summary0013382: Unable to add new timesheets
DescriptionWhen adding an new timesheet the form won't load, the animation spins and the page stays with the gray overlay.
The console shows "TypeError: this.action_add_from_filemanager is undefined" as error.
The form for new timesheets is unusable in that way. I tried it with Firefox and Chromium under Fedora 26.
TagsNo tags attached.
mwticket

Activities

johnassel

johnassel

2017-08-10 15:51

reporter   ~0020548

It was an update from a previous version by extracting the full zip archive and copying the configuration file back.
mspahn

mspahn

2017-08-10 18:48

administrator   ~0020556

Last edited: 2017-08-10 18:50

View 2 revisions

http://gerrit.tine20.com/customers/#/c/5450/

mspahn

mspahn

2017-08-10 18:52

administrator   ~0020558

Last edited: 2017-08-10 18:53

View 2 revisions

Cheers, good catch, is resolved.

Using this patch requires rebuild of all fat files, I think we'll provide soon an update package.



0013382__Unable_to_add_new_timesheets.patch (809 bytes)
Index: tine20/Tinebase/js/widgets/grid/FileUploadGrid.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- tine20/Tinebase/js/widgets/grid/FileUploadGrid.js	(revision b0c8f9236e17d91c9ce621a82e8c255322658b20)
+++ tine20/Tinebase/js/widgets/grid/FileUploadGrid.js	(revision 82793664cb15399a7e05517f26d986a337b70389)
@@ -117,7 +117,10 @@
         this.readOnly = readOnly;
         this.action_add.setDisabled(readOnly);
         this.action_remove.setDisabled(readOnly);
-        this.action_add_from_filemanager.setDisabled(readOnly);
+
+        if (Tine.Tinebase.appMgr.isEnabled('Filemanager')) {
+            this.action_add_from_filemanager.setDisabled(readOnly);
+        }
     },
 
     /**
mspahn

mspahn

2017-08-10 18:54

administrator   ~0020560

A workaround would be to enable the filemanager.
johnassel

johnassel

2017-08-10 19:08

reporter   ~0020562

Enabling the filemanager worked.
How to I apply the patch? The file stated in the patch-file doesn't exist in my installation?

Issue History

Date Modified Username Field Change
2017-08-10 15:48 johnassel New Issue
2017-08-10 15:51 johnassel Note Added: 0020548
2017-08-10 18:47 mspahn Assigned To => mspahn
2017-08-10 18:48 mspahn Status new => gerrit
2017-08-10 18:48 mspahn Note Added: 0020556
2017-08-10 18:50 mspahn Note Edited: 0020556 View Revisions
2017-08-10 18:52 mspahn File Added: 0013382__Unable_to_add_new_timesheets.patch
2017-08-10 18:52 mspahn Note Added: 0020558
2017-08-10 18:53 mspahn Note Edited: 0020558 View Revisions
2017-08-10 18:54 mspahn Note Added: 0020560
2017-08-10 19:08 johnassel Note Added: 0020562
2017-08-11 11:26 pschuele Target Version => 2017.08.2 Community Edition
2017-08-11 11:26 pschuele Status gerrit => resolved
2017-08-11 11:26 pschuele Resolution open => fixed
2017-08-11 11:26 pschuele Fixed in Version => 2017.08.2 Community Edition